chore: increases phpstan level to 1 (algolia#892)

ctidigital · Oct 24, 2019 · 4f2960f · 4f2960f
1 parent bd00c4b
commit 4f2960f
Show file tree

Hide file tree

Showing 8 changed files with 31 additions and 7 deletions.
diff --git a/Block/LandingPage.php b/Block/LandingPage.php
@@ -10,6 +10,9 @@
 use Magento\Cms\Model\Template\FilterProvider;
 use Magento\Search\Model\QueryFactory;
 
+/**
+ * @method int getPageId()
+ */
 class LandingPage extends Result
 {
     /** @var FilterProvider */

diff --git a/Helper/Data.php b/Helper/Data.php
@@ -553,7 +553,7 @@ private function getCategoryRecords($storeId, $collection, $potentiallyDeletedCa
                 unset($potentiallyDeletedCategoriesIds[$categoryId]);
             }
 
-            if (isset($categorysToIndex[$categoryId]) || isset($categorysToRemove[$categoryId])) {
+            if (isset($categoriesToIndex[$categoryId]) || isset($categoriesToRemove[$categoryId])) {
                 continue;
             }
 

diff --git a/Model/Job.php b/Model/Job.php
@@ -17,6 +17,7 @@
  * @method int getMaxRetries()
  * @method array getDecodedData()
  * @method array getMergedIds()
+ * @method $this setErrorLog(string $message)
  * @method $this setPid($pid)
  * @method $this setRetries($retries)
  * @method $this setStoreId($storeId)

diff --git a/Model/Layer/Filter/Decimal.php b/Model/Layer/Filter/Decimal.php
@@ -4,6 +4,12 @@
 
 use Algolia\AlgoliaSearch\Helper\ConfigHelper;
 
+/**
+ * @method $this setMinValue(float $value)
+ * @method $this setMaxValue(float $value)
+ * @method string getFrom(string $value)
+ * @method string getTo(string $value)
+ */
 class Decimal extends \Magento\CatalogSearch\Model\Layer\Filter\Decimal
 {
     /** @var \Magento\Catalog\Model\Layer\Filter\DataProvider\Price */

diff --git a/Model/Layer/Filter/Item/Attribute.php b/Model/Layer/Filter/Item/Attribute.php
@@ -2,6 +2,12 @@
 
 namespace Algolia\AlgoliaSearch\Model\Layer\Filter\Item;
 
+/**
+  * @method bool getIsSelected()
+  * @method mixed getValue()
+  * @method mixed getApplyFilterValue()
+  * @method string getLabel()
+  */
 class Attribute extends \Magento\Catalog\Model\Layer\Filter\Item
 {
     /**
@@ -41,9 +47,12 @@ public function getRemoveUrl()
                 }
             }
 
+            $resetValue = null;
+
             if (!is_null($idToRemove)) {
                 $resetValue = array_diff($this->getApplyValue(), [$idToRemove]);
             }
+
             $query = [$this->getFilter()->getRequestVar() => implode('~', $resetValue)];
         }
 

diff --git a/Model/Layer/Filter/Price.php b/Model/Layer/Filter/Price.php
@@ -4,6 +4,11 @@
 
 use Algolia\AlgoliaSearch\Helper\ConfigHelper;
 
+/**
+ * @method $this setMinValue(float $value)
+ * @method $this setMaxValue(float $value)
+ * @method $this setCurrentValue(array<string, float> $value)
+ */
 class Price extends \Magento\CatalogSearch\Model\Layer\Filter\Price
 {
     /** @var \Magento\Catalog\Model\Layer\Filter\DataProvider\Price */

diff --git a/ViewModel/Adminhtml/Analytics/Overview.php b/ViewModel/Adminhtml/Analytics/Overview.php
@@ -173,6 +173,9 @@ public function getDailySearchData()
         $searches = $this->getSearchesByDates();
         $users = $this->getUsersCountByDates();
         $rates = $this->getResultRateByDates();
+        $clickPosition = null;
+        $conversion = null;
+        $ctr = null;
 
         if ($this->isClickAnalyticsEnabled()) {
             $clickPosition = $this->getClickPositionByDates();
@@ -452,10 +455,10 @@ public function getMessagesHtml()
             ->createBlock(\Magento\Framework\View\Element\Messages::class);
 
         if (!$this->checkIsValidDateRange() && $this->isAnalyticsApiEnabled()) {
-            $noticeHtml = __('The selected date is out of your analytics retention window (%1 days), 
+            $noticeHtml = __('The selected date is out of your analytics retention window (%1 days),
                 your data might not be present anymore.', $this->getAnalyticRetentionDays());
             $noticeHtml .= '<br/>';
-            $noticeHtml .= __('To increase your retention and access more data, you could switch to a 
+            $noticeHtml .= __('To increase your retention and access more data, you could switch to a
                 <a href="%1" target="_blank">higher plan.</a>', 'https://www.algolia.com/billing/overview/');
 
             $messagesBlock->addNotice($noticeHtml);

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,5 @@
 parameters:
-    level: 0
+    level: 1
     reportUnmatchedIgnoredErrors: false
     paths:
         - vendor/algolia/algoliasearch-magento-2/Adapter
@@ -18,7 +18,4 @@ parameters:
         - vendor/algolia/algoliasearch-magento-2/ViewModel
         - vendor/algolia/algoliasearch-magento-2/registration.php
     ignoreErrors:
-        - '#(class|type) Magento\\\S*Factory#i'
-        - '#(class|type) Algolia\\\S*Factory#i'
         - '#Call to static method getObjectManager\(\) on an unknown class Magento\\TestFramework\\Helper\\Bootstrap.#'
-        - '#Parameter \$clientFactory of method Algolia\\AlgoliaSearch\\Helper\\AlgoliaHelper::__construct\(\) has invalid typehint type AlgoliaSearch\\ClientFactory.#'