-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MW-OAuth2Client-Gamma with OpenIDConnect #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with php, but from what I can see and read in the mediawiki documentation it looks good.
However, in the README there is a mention of updating from earlier than version 1.39, but we still use version 1.35 in the dockerfile.
Additionally we've removed the old GAMMA_AUTHORIZED_GROUPS environment variable it seems. Do we have some other way of limiting access to certain wikis?
All in all it looks great though!
Oops, don't know how I missed upgrading to 1.39. I will go ahead and fix that. GAMMA_AUTHORIZED_GROUPS was removed in part due to the new framework not supporting it but also that Gamma 2.0 allows you to put restrictions on which groups may authenticate with that client. |
Allright! Ah yeah I forgot about that detail in Gamma 2.0 😋. Thanks for the explanation, in that case I'll approve as soon as the mediawiki is updated. I have however read some reports of mediawiki 1.39 breaking if you use the Vector 2022 extension due to it being bundled with 1.39 so just beware of that. |
Actually, scratch that, it appears to only affect instances where the Vector 2022 extension was installed before the update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 😎
This allows configuration towards more generic OpenID Connect issuers, including Gamma. It's still not entirely generic however, as some claims (such as cid for username) will need to be hard coded.
UX Improvements
Code Improvements
Known Issues