Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MW-OAuth2Client-Gamma with OpenIDConnect #4

Merged
merged 12 commits into from
Jul 28, 2024
Merged

Conversation

GAsplund
Copy link
Member

@GAsplund GAsplund commented May 5, 2024

This allows configuration towards more generic OpenID Connect issuers, including Gamma. It's still not entirely generic however, as some claims (such as cid for username) will need to be hard coded.

UX Improvements

  • New themes: Cititzen, Vector 2022 and Minerva Neue
  • Use Vector 2022 as default skin for mobile compatibility
  • New extensions: PdfHandler, Math and MultimediaViewer

Code Improvements

  • Documentation in README.md
  • Remove old Gamma docker-compose (use the centrally hosted Gamma for development)

Known Issues

  • There is no way to log in directly through Gamma without navigating to the login form or disabling local login
    • Login via Gamma is done through PluggableAuth that sends a POST request directly from the browser to the login endpoint to get redirected

@GAsplund GAsplund marked this pull request as ready for review July 27, 2024 10:09
Copy link

@simon-wg simon-wg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with php, but from what I can see and read in the mediawiki documentation it looks good.

However, in the README there is a mention of updating from earlier than version 1.39, but we still use version 1.35 in the dockerfile.

Additionally we've removed the old GAMMA_AUTHORIZED_GROUPS environment variable it seems. Do we have some other way of limiting access to certain wikis?

All in all it looks great though!

@GAsplund
Copy link
Member Author

I'm not too familiar with php, but from what I can see and read in the mediawiki documentation it looks good.

However, in the README there is a mention of updating from earlier than version 1.39, but we still use version 1.35 in the dockerfile.

Additionally we've removed the old GAMMA_AUTHORIZED_GROUPS environment variable it seems. Do we have some other way of limiting access to certain wikis?

All in all it looks great though!

Oops, don't know how I missed upgrading to 1.39. I will go ahead and fix that.

GAMMA_AUTHORIZED_GROUPS was removed in part due to the new framework not supporting it but also that Gamma 2.0 allows you to put restrictions on which groups may authenticate with that client.

@simon-wg
Copy link

Allright! Ah yeah I forgot about that detail in Gamma 2.0 😋.

Thanks for the explanation, in that case I'll approve as soon as the mediawiki is updated.

I have however read some reports of mediawiki 1.39 breaking if you use the Vector 2022 extension due to it being bundled with 1.39 so just beware of that.

@simon-wg
Copy link

Actually, scratch that, it appears to only affect instances where the Vector 2022 extension was installed before the update.

Copy link

@simon-wg simon-wg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 😎

@GAsplund GAsplund merged commit 06b0d94 into master Jul 28, 2024
2 checks passed
@GAsplund GAsplund deleted the feature/gamma-2.0 branch July 28, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants