If "Created Time", "Modified Time", or "Accessed Time" are the start of the 1979 epoch, an out of range exception is thrown. #485
Labels
Comments
|
yes, ZIP uses MSDOS epoch 1/1/1980 and javascript does use UNIX epoch 1/1/1970 most likely value is negative. |
This was referenced Jan 29, 2025
avi-alpert
added a commit
to aws/aws-toolkit-vscode
that referenced
this issue
Jan 31, 2025
## Problem Users see a `Sorry, I ran into an issue while trying to upload your code` error when using /dev or /doc if files in the repo have a modified or created time before the MSDOS epoch. This affects some users who Remote SSH into a Linux machine. Logs show an out of range exception thrown from the adm-zip package. Adm-zip issue reported [here](cthackers/adm-zip#485) ## Solution Switch to the internal [zipStream module](https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/shared/utilities/zipStream.ts) --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After some investigation, I have figured out what went wrong for me. Hopefully this will help others. The issue in my case was that the "LastModifiedTime" and "CreatedTime" were the default 1979 timestamps. I used BulkFileChanger (https://www.nirsoft.net/utils/bulk_file_changer.html) to edit all my files to have a new time. This fixed it for me.
This happened because I copied items directly from another archive without unzipping first.
I figured this out by observing the exception happen on line 256.
Originally posted by @TheRedstoneScientist in #426 (comment)
The text was updated successfully, but these errors were encountered: