deps(amazonq): upgrade adm-zip to 0.5.16 #6463
Closed
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/runIntegrationTests |
|
I think this change is fine but just for a heads up, instead of using adm-zip we should be migrating to our zipStream utility instead. It will allow us to eventually run agents in the browser + I think? resolve some memory issues as well |
|
Will look into switching to zipstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users get an error uploading files when using /dev or /doc if files modified/created time is before the MSDOS epoch. Logs show an out of range exception thrown from the adm-zip package. Adm-zip issue reported here
Solution
Upgrade adm-zip to the latest version. Use posix join to test paths in a zip, since adm-zip was updated to be POSIX compliant cthackers/adm-zip#438
feature/xbranches will not be squash-merged at release time.