ci: remove IaC for integration tests in favor of Github workflow service

.github/workflows/ci.yaml

@@ -1,5 +1,4 @@
 name: CI
-
 on: [push, pull_request]
 
 jobs:
@@ -11,7 +10,7 @@ jobs:
         with:
           access_token: ${{ github.token }}
 
-  unit-tests:
+  tests:
     strategy:
       matrix:
         go-version: [1.x, 1.21.x]
@@ -22,6 +21,11 @@ jobs:
             update-coverage: true
     runs-on: ${{ matrix.platform }}
     needs: [setup]
+    services:
+      ctfd:
+        image: ctfd/ctfd:3.6.1
+        ports:
+          - 8000:8000
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -38,14 +42,16 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: ${{ runner.os }}-go-
 
-      - name: Run go test
-        run: go test -v -race -coverprofile coverage.txt ./...
-
+      - name: Run go tests
+        run: make tests
+        env:
+          CTFD_URL: http://ctfd:8000
+
       - name: Upload coverage to Coveralls
         if: ${{ matrix.update-coverage }}
         uses: shogo82148/actions-goveralls@v1
         with:
-          path-to-profile: coverage.txt
+          path-to-profile: functional.out
 
   go-lint:
     runs-on: ubuntu-latest

Makefile

@@ -4,8 +4,8 @@ tests:
 	go test ./api -run=^Test_U_ -json | tee -a gotest.json
 
 	@echo "--- Functional tests ---"
-	go test ./deploy/integration -run=^Test_F_ -json -coverpkg "github.com/ctfer-io/go-ctfd/api" -coverprofile=functional.out | tee -a gotest.json
+	go test ./api -run=^Test_F_ -coverprofile=functional.out -json | tee -a gotest.json
 
 .PHONY: clean
 clean:
-	rm gotest.json unitary.out functional.out
+	rm gotest.json functional.out

api/main_test.go

@@ -0,0 +1,26 @@
+package api_test
+
+import (
+	"fmt"
+	"os"
+	"testing"
+)
+
+var (
+	CTFD_URL = ""
+)
+
+func TestMain(m *testing.M) {
+	u, ok := os.LookupEnv("CTFD_URL")
+	if !ok {
+		fmt.Println("Environment variable CTFD is not set, please indicate the domain name/IP address to reach out the cluster.")
+		os.Exit(1)
+	}
+	CTFD_URL = u
+
+	os.Exit(m.Run())
+}
+
+func ptr[T any](t T) *T {
+	return &t
+}

api/reset.go

@@ -1,23 +1,24 @@
 package api
 
 import (
-	"bytes"
-	"encoding/json"
 	"fmt"
 	"net/http"
+	"net/url"
+	"strings"
 
+	"github.com/gorilla/schema"
 	"github.com/pkg/errors"
 )
 
 type ResetParams struct {
-	Accounts      *string `json:"accounts,omitempty"`
-	Submissions   *string `json:"submissions,omitempty"`
-	Challenges    *string `json:"challenges,omitempty"`
-	Pages         *string `json:"pages,omitempty"`
-	Notifications *string `json:"notifications,omitempty"`
+	Accounts      *string `schema:"accounts,omitempty"`
+	Submissions   *string `schema:"submissions,omitempty"`
+	Challenges    *string `schema:"challenges,omitempty"`
+	Pages         *string `schema:"pages,omitempty"`
+	Notifications *string `schema:"notifications,omitempty"`
 	// Nonce is autofilled by the API wrapper.
 	// XXX the "nonce" should not be part of the API call but rather be extracted from HTTP headers.
-	Nonce string `json:"nonce"`
+	Nonce string `schema:"nonce"`
 }
 
 func (client *Client) Reset(params *ResetParams, opts ...Option) error {
@@ -27,11 +28,16 @@ func (client *Client) Reset(params *ResetParams, opts ...Option) error {
 	}
 
 	// Build request
-	body, err := json.Marshal(params)
-	if err != nil {
-		return errors.Wrap(err, "during JSON marshalling")
+	str := ""
+	if params != nil {
+		val := url.Values{}
+		if err := schema.NewEncoder().Encode(params, val); err != nil {
+			return err
+		}
+		str = val.Encode()
 	}
-	req, _ := http.NewRequest(http.MethodPost, "/admin/reset", bytes.NewBuffer(body))
+	req, _ := http.NewRequest(http.MethodPost, "/admin/reset", strings.NewReader(str))
+	req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 
 	res, err := client.Do(req)
 	if err != nil {