optimization of multiplicity, theta and gh cut #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 94.33% 95.78% +1.44%
==========================================
Files 58 59 +1
Lines 2738 2845 +107
==========================================
+ Hits 2583 2725 +142
+ Misses 155 120 -35
☔ View full report in Codecov by Sentry. |
maxnoe
force-pushed
the
faster_optimize_cuts
branch
from
62b8b8b to
46ec05f
Compare
kosack
requested changes
Sep 15, 2023
| Bins in reconstructed energy to use for sensitivity computation | ||
| gh_cut_efficiencies: np.ndarray[float, ndim=1] | ||
| The cut efficiencies to scan for best sensitivity. | ||
| theta_cuts: astropy.table.QTable |
There was a problem hiding this comment.
This doc is wrong: it's not the cuts being passed here, but the array of values over which the brute-force optimization scan is done, right? Also, for symmetry, shouldn't there be a similar input for multiplicity?
| ---------- | ||
| values: ``~numpy.ndarray`` or ``~astropy.units.Quantity`` | ||
| The values on which the cut should be evaluated | ||
| cut_table: ``~astropy.table.Table`` |
maxnoe
commented
Dec 2, 2024
…was overwriting the gh and theta cuts, instead of saving them separately.
maxnoe
commented
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.