SolcStandardJson: pass solc_env and solc_working_dir through to compilation #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garythung
commented
Nov 1, 2023
•
garythung
commented
- Adds an optional kwarg to the SolcStandardJson platform so you can specify the solc version. Otherwise, it runs whichever solc version is currently active.
- pass the solc_working_dir variable through to compilation
garythung
requested review from
montyly,
0xalpharush and
bohendo
as code owners
|
|
garythung
changed the title
|
This is great, thanks @garythung |
montyly
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.