Updating the chromedriver install location #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zip is extracted. Fixes #13
jwoertink
commented
Oct 20, 2023
jwoertink
commented
Oct 20, 2023
jwoertink
commented
Oct 20, 2023
matthewmcgarvey
requested changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Starting with chrome v115, they changed where the files are downloaded. They also changed the structure of the zip files.
This PR still allows you to pull up the old chromedriver versions, but also takes in to account later versions. If you have a specific version of the Chrome browser installed, it will attempt to find the matching chromedriver, otherwise it just grabs the latest Stable version.