Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor recent Lint/Unused* specs #562

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor recent Lint/Unused* specs #562

wants to merge 4 commits into from

Conversation

nobodywasishere
Copy link
Contributor

This was my understanding of the changes in #561. If I missed something, let me know and I can update these.

@nobodywasishere nobodywasishere marked this pull request as ready for review February 5, 2025 06:49
@Sija Sija added this to the 1.7.0 milestone Feb 5, 2025
@Sija Sija added the refactor label Feb 5, 2025
Sija
Sija requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside of my comments, I've noticed we're missing test coverage for AST::ImplicitReturnVisitor - this can be done in a followup PR though.

spec/ameba/rule/lint/unused_comparison_spec.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/unused_generic_or_union_spec.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/unused_literal_spec.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/unused_literal_spec.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/unused_literal_spec.cr Outdated Show resolved Hide resolved
@nobodywasishere nobodywasishere force-pushed the nobody/refactor-unused-specs branch from 1473a3d to 2ce175a Compare February 5, 2025 21:51
@Sija Sija requested review from Sija and veelenga February 6, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Awaiting requested review from Sija

@veelenga veelenga Awaiting requested review from veelenga

Requested changes must be addressed to merge this pull request.

Assignees

@nobodywasishere nobodywasishere

Labels
refactor
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nobodywasishere @Sija