Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining Chacha20Poly1305 tests to new crate structure #831

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Migrate remaining Chacha20Poly1305 tests to new crate structure #831

merged 4 commits into from
Feb 17, 2025

Conversation

keks
Copy link
Member

@keks keks commented Feb 13, 2025

Fixes #797
Fixes #822

@keks keks requested a review from a team as a code owner February 13, 2025 16:41
jschneider-bensch
jschneider-bensch approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good! Just have a question about the pretty_env_logger dependency.

chacha20poly1305/tests/chachapoly.rs Outdated Show resolved Hide resolved
@keks keks merged commit 4294b42 into main Feb 17, 2025
65 checks passed
@keks keks deleted the keks/test-chachapoly branch February 17, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschneider-bensch jschneider-bensch jschneider-bensch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test that fails if the wrong ciphertext length is used in Chacha20Poly1305 Adapt tests in chachapoly.rs
2 participants
@keks @jschneider-bensch