-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMD: add a model #815
base: main
Are you sure you want to change the base?
SIMD: add a model #815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks like it's quite ready though.
Let's move this into a separate directory for proofs (where we can move the other proof related parts too). Having this on the top level clutters things even more. We'll move crates as well soon.
Also, the high level description needs to explain what this crate is doing and how.
minicore/src/arch/x86.rs
Outdated
#[allow(non_camel_case_types)] | ||
type __m128i = BitVec<128>; | ||
|
||
pub fn _mm_storeu_si128(output: *mut __m128i, a: __m128i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these functions should get a description of what they are doing when we want to use this as a source of truth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can copy-paste docs from rust core or intel, shall I do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rust docs are pretty limited and sometimes wrong I think. But the the gist from the intel docs with a link would be good.
Co-authored-by: Franziskus Kiefer <[email protected]>
Thanks for the review. |
Yeah, I guess that should be a more general |
I did the changes, but I'm not sure about the docs of the intrinsics actually. I wonder if we should not instead expose the body of the function as docstring, somehow. |
Review re-requested
This PR inits a new crate,
minicore
.For now, this covers only a small subset of
core::arch::x86_64
andcore::arch::x86
.This PR adds: