[PSQ] Introduce features classic-mceliece and non-pq
#790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
previously requested changes
Feb 4, 2025
franziskuskiefer
added
the
waiting-on-author
Review: get rid of lifetimes in traits Review: Use `libcrux_kem` types directly Review: Add TODOs for `no_std` issues Review: simplify return Review: Keypair alias, keygen in KEM trait Use `classic_mceliece_rust` types directly Review: Move `KEM` trait to `libcrux-traits` Review: Add todo for constant time ops
…into jonas/psq-mceliece-gate
jschneider-bensch
removed
the
waiting-on-author
github-actions
bot
dismissed
franziskuskiefer’s stale review
Review re-requested
franziskuskiefer
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new features to the
libcrux-psqcrate:classic-mceliece: This makes the Classic McEliece implementation usingclassic-mceliece-rustavailable. The rationale is that we would like the default feature set to have as little dependencies as possible, so we introduce this feature until we eventually have Classic McEliece inlibcrux.non-pq: This makes theX25519implementation available. We included this for testing and benchmarking against the fully PQ or hybrid KEMs, but it should not be availiable as a default feature, since it provides no PQ security.To introduce these features I've restructured algorithm selection to using traits. Every PSQ implementation now implements the
PSQtrait, which relies on an associated typeInnerKEMthat provides the interface for the underlying KEM. It should not be allowed for users of the crate to implement thePSQtrait, so I've sealed the underlying KEM interface.Fixes #722