Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine/deps): fix inverted behavior for including dependencies #484

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix(engine/deps): fix inverted behavior for including dependencies #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions engine/lib/dependencies.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,11 @@ module Make (F : Features.T) = struct
let apply_clause selection' (clause : Types.inclusion_clause) =
let matches = Concrete_ident.matches_namespace clause.Types.namespace in
let matched = Set.filter ~f:matches selection in
let without_deps =
[%matches? (Included { strict = true } : Types.inclusion_kind)]
let with_deps =
[%matches? (Included { strict = false } : Types.inclusion_kind)]
clause.kind
in
let matched = matched |> if without_deps then Fn.id else deps_of in
let matched = matched |> if with_deps then deps_of else Fn.id in
Logs.info (fun m ->
m "The clause [%s] will %s the following Rust items:\n%s"
(show_inclusion_clause clause)
Expand Down
Loading