Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix select_trait_candidate #478

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jan 30, 2024

Fixes #461 and #476

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes hax crash. For example

Fatal error: exception Failure("impl_expr_atom: Todo ImplExprAtom::Todo(see https://github.com/hacspec/hax/issues/381) ImplSourceClosureData(closure_def_id=DefId(0:673 ~ bertie[019b]::tls13utils::{impl#3}::declassify::{closure#0}), substs=[i16, extern \"rust-call\" fn((&u8,)) -> u8, ()], nested=[Obligation(predicate=Binder(ClosureKind(DefId(0:673 ~ bertie[019b]::tls13utils::{impl#3}::declassify::{closure#0}), [i16, extern \"rust-call\" fn((&u8,)) -> u8, ()], FnMut), []), depth=1)])\n\nBinder(\n    <[closure@src/tls13utils.rs:202:27: 202:30] as std::ops::FnMut<(&u8,)>>,\n    [],\n)")
Raised at Stdlib.failwith in file "stdlib.ml", line 29, characters 17-33
Called from Hax_engine__Import_thir.Make.c_impl_expr in file "lib/import_thir.ml", line 906, characters 15-44

@W95Psp
Copy link
Collaborator Author

W95Psp commented Jan 31, 2024

Yes, I noticed it's producing new bugs 😅
But that is fine: those are just new cases I need to take care of, I see what is the problem, that's just some small legitimate changes to do :)

@W95Psp W95Psp force-pushed the fix-select-trait-candidate branch from ebf9995 to 8d18742 Compare January 31, 2024 16:27
@W95Psp W95Psp force-pushed the fix-select-trait-candidate branch from 52c0166 to 8d18742 Compare February 1, 2024 08:08
@franziskuskiefer
Copy link
Member

you force pushed again 😔

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in

@W95Psp W95Psp added this pull request to the merge queue Feb 1, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Feb 1, 2024

Great, thank you 😃

Merged via the queue into main with commit 572fb6e Feb 1, 2024
20 checks passed
@W95Psp W95Psp deleted the fix-select-trait-candidate branch February 1, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extraction fails with select_trait_candidate
2 participants