Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Primitives Abstraction Layer #459

Merged
merged 23 commits into from
Jan 29, 2024
Merged

Conversation

jschneider-bensch
Copy link
Contributor

@jschneider-bensch jschneider-bensch commented Jan 25, 2024

This PR introduces an abstraction layer for cryptographic primitives in the hax_lib_protocol crate and rewrites the Noise example to use only that.
The abstraction layer at the moment is just a thin wrapper around libcrux but in the future could be extended to other backends.

Two things before this is ready for review:

  • Docs for the abstraction layer
  • ProVerif extraction of the Noise example seems to go into an infinite loop

Fixes #453.

@spitters
Copy link
Collaborator

Just curious, will it fit with the crates in https://github.com/RustCrypto ?
They are interested in hacspec integration:
RustCrypto/meta#9

@jschneider-bensch
Copy link
Contributor Author

Haven't looked at how to integrate with the RustCrypto traits, so far. But that might be a future alternative "backend" for these abstractions besides libcrux.

@jschneider-bensch jschneider-bensch marked this pull request as ready for review January 25, 2024 15:32
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Just a few nits and questions.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in.

@jschneider-bensch jschneider-bensch added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 3c4cfec Jan 29, 2024
10 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/crypto-abstractions branch January 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ProVerif] Define crypto abstraction layer
3 participants