Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine/fstar): always name binders on vals #403

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix(engine/fstar): always name binders on vals #403

merged 1 commit into from
Jan 5, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Dec 21, 2023

This PR adds binder names as much as possible when producing val declarations in fsti interfaces F* files.
I say "as much as possible" because of issue #402.

franziskuskiefer
franziskuskiefer approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this slipped through. Let's get it in.

@W95Psp W95Psp added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 8ecf9c6 Jan 5, 2024
10 checks passed
@W95Psp W95Psp deleted the fix-fstar-interfaces branch January 5, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@karthikbhargavan karthikbhargavan Awaiting requested review from karthikbhargavan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W95Psp @franziskuskiefer