Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProVerif protocol traits #395

Merged
merged 14 commits into from
Jan 3, 2024
Merged

ProVerif protocol traits #395

merged 14 commits into from
Jan 3, 2024

Conversation

jschneider-bensch
Copy link
Contributor

This PR introduces two helper libraries:

  • hax-lib-protocol which defines traits for building protocol implementations in hax.
  • hax-lib-protocol-macros which defines macros that automatically implement the traits from hax-lib-protocol

The two libraries are exemplified in a new test for the ProVerif backend.

The PR also introduced new macros in hax-lib-macros to mark process components, although these are not yet acted on in the ProVerif backend.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I added a couple comments and questions.

Please add comments everywhere to make it easier to understand what's going on.

I have a couple of design questions that we may want to leave for a second iteration after this got merged.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get it in to get it used.

@jschneider-bensch jschneider-bensch added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit f79dc5c Jan 3, 2024
9 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/protocol-traits branch January 3, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants