Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine) Fix return inside closure. #1303

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(engine) Fix return inside closure. #1303

merged 1 commit into from
Feb 10, 2025

Conversation

maximebuyse
Copy link
Contributor

Fixes #1300

The problem is that returns inside closures only break the control flow of the closure and not of the outter function.

@maximebuyse maximebuyse requested a review from a team as a code owner February 10, 2025 11:24
@maximebuyse maximebuyse requested a review from W95Psp February 10, 2025 11:25
W95Psp
W95Psp approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense! Thanks, let's merge :)

@W95Psp W95Psp added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 2cf409d Feb 10, 2025
15 checks passed
@W95Psp W95Psp deleted the fix-1300 branch February 10, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error in side_effect_utils.ml
2 participants
@maximebuyse @W95Psp