Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine) Use ocamlgraph fork to fix missing rec bug. #1228

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

maximebuyse
Copy link
Contributor

Fixes #1158

This changes the version of ocamlgraph we use to avoid backtracking/ocamlgraph#149. The ocamlgraph is implemented in this fork/branch: https://github.com/maximebuyse/ocamlgraph/tree/fix-stable-topological-sort

In the case of functions that are mutually recursive with an impl method, the examples still don't work. Reproducer:

pub trait A{
    fn f(&self);
}
impl A for i32 {

    fn f(&self){
        g(*self)
    }
}
pub fn g(x: i32) {x.f()}

Open this code snippet in the playground

But this is documented in #616

@maximebuyse maximebuyse requested a review from W95Psp January 14, 2025 12:42
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maximebuyse maximebuyse added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit fcc06df Jan 14, 2025
15 checks passed
@maximebuyse maximebuyse deleted the fix-missing-rec branch January 14, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine: F*: Missing rec qualifier in a mutually recursive top-level let
2 participants