Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EBNF for AST to book #1066

Merged
merged 18 commits into from
Jan 13, 2025
Merged

Add EBNF for AST to book #1066

merged 18 commits into from
Jan 13, 2025

Conversation

cmester0
Copy link
Collaborator

No description provided.

@cmester0 cmester0 marked this pull request as draft October 29, 2024 12:02
@cmester0
Copy link
Collaborator Author

File generated by #1038 and #986

@W95Psp
Copy link
Collaborator

W95Psp commented Oct 31, 2024

We chatted about this, we said we should put that file in the book directly in a "Input language" section that contains the grammar for the input language (filtering features already for Features.Rust only) and a small summary of https://github.com/hacspec/hax/issues?q=is%3Aissue%20is%3Aopen%20label%3Aunsupported-rust%20

@W95Psp
Copy link
Collaborator

W95Psp commented Nov 26, 2024

@cmester0 shall this be still a draft PR?

@cmester0 cmester0 marked this pull request as ready for review November 26, 2024 15:45
@W95Psp
Copy link
Collaborator

W95Psp commented Nov 28, 2024

Let's chat, it feels like some rules are missing, e.g. generic params

franziskuskiefer
franziskuskiefer reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added to the SUMMARY.md to show up in the book.

book/src/contributing/ast_ebnf.md Outdated Show resolved Hide resolved
W95Psp
W95Psp reviewed Dec 3, 2024
View reviewed changes
book/src/SUMMARY.md Outdated Show resolved Hide resolved
@W95Psp
Copy link
Collaborator

W95Psp commented Dec 11, 2024 •
edited
Loading

Shall I review again @cmester0? is this in a good shape?
We should backport things from the paper probably.

Also there is a conflict

@W95Psp
Copy link
Collaborator

W95Psp commented Jan 13, 2025

@franziskuskiefer I think this is good now, let me know if anything is off

@franziskuskiefer
Copy link
Member

@franziskuskiefer I think this is good now, let me know if anything is off

lgtm, do you want to merge this before #1225, or fold it in there?

@W95Psp
Copy link
Collaborator

W95Psp commented Jan 13, 2025

Let's merge now, I'll rebase the other PR!

@W95Psp W95Psp added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit efc913c Jan 13, 2025
15 checks passed
@W95Psp W95Psp deleted the AST-EBNF-documentation branch January 13, 2025 17:18
@W95Psp W95Psp mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

@karthikbhargavan karthikbhargavan Awaiting requested review from karthikbhargavan

@franziskuskiefer franziskuskiefer Awaiting requested review from franziskuskiefer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmester0 @W95Psp @franziskuskiefer