-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to reStructuredText + sphinx #371
Conversation
@lvh I think it's ready! |
@multun Hey, just a heads up with a little luck I'll be reviewing this today. Thanks again for all the work you've put in here. |
@multun I think ownership of the Transifex organization makes sense. |
@lvh cool! send me your username, and I'll do just that |
Bizarrely, |
@multun Do you have any examples of this issue:
The links I found appeared to mostly work? |
It only occurs with auto-numbered footnotes ( |
@multun oops, sorry, try again :) |
@lvh you now are administrator and maintainer of the crypto101 organization! It's pretty empty for now, but I'm pretty sure it'll change soon :) |
Thanks! I've been hitting a snag with the build via docker:
I'll try and figure out what's up with that. I imagine it's a dirty build dir. |
I think what might have happened is that I was using the wrong language code. I used |
Here's the list, I'll update the readme soon |
@lvh I added some documentation about language codes, sorry for the delay |
There should probably be a ticket for caching the docker build, since right now it downloads a lot of stuff every time. |
I pushed a built image to the docker hub, you can get it with |
This is enough of an improvement (and has been open long enough) that I'm just going to merge it, and we'll deal with any remaining issues as they come. Thanks @multun!!! |
This pull request does the following:
Moving to rst + sphinx has a number of avantages:
As this pull request touches every single line of source in the repository, it probably broke something. It really needs some testing.
You can preview an html build at https://crypto101.multun.net/
I also intend to help translate the book into french.
Known issues:
pagebackref
advanced
warnings could look better:term:
Thanks @lvh for your amazing book! Do you want the ownership of the crypto101 transifex organisation?
Fixes #62
Related to #362 #348