forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: concurrent map read and write from priority nonce mempool #681
Closed
mmsqe
wants to merge
10
commits into
crypto-org-chain:release/v0.50.x
from
mmsqe:release/v0.50.x_mempool_lock
Closed
Problem: concurrent map read and write from priority nonce mempool #681
mmsqe
wants to merge
10
commits into
crypto-org-chain:release/v0.50.x
from
mmsqe:release/v0.50.x_mempool_lock
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
force-pushed
the
release/v0.50.x_mempool_lock
branch
from
August 22, 2024 02:10
87e087b
to
91b469c
Compare
yihuang
reviewed
Aug 22, 2024
types/mempool/priority_nonce.go
Outdated
@@ -287,6 +287,7 @@ func (mp *PriorityNonceMempool[C]) Insert(ctx context.Context, tx sdk.Tx) error | |||
|
|||
func (i *PriorityNonceIterator[C]) iteratePriority() Iterator { | |||
// beginning of priority iteration | |||
i.mempool.mtx.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, but the fix seems tricky, instead of access priorityIndex/priorityNode directly, I'm thinking wrap sth like
type atomicPriorityIndex struct {
atomic.RWMutex
priorityIndex *ListIndex
priorityNode *ListNode
}
func (i *atomicPriorityIndex) SetIndex(xxx) {
// lock
i.priorityIndex.Set(xxx)
}
func (i *atomicPriorityIndex) NextNode() *ListNode {
// lock
return i.priorityNode.Next()
}
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #675
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...