Problem: gas_used differs in getting of consensusParams when enable cache #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnations of same tx (cosmos#565)" This reverts commit 5a1594f.
yihuang
reviewed
Aug 7, 2024
yihuang
approved these changes
Aug 7, 2024
mmsqe
changed the title
|
I'm not sure if we can align the gas_used since there'd be less GetConsensusParams when enable cache. Or do you mean we record the gas_used like f33944e |
yihuang
reviewed
Aug 7, 2024
| @@ -842,8 +842,8 @@ func (app *BaseApp) internalFinalizeBlock(ctx context.Context, req *abci.Request | |||
|
|
|||
| func (app *BaseApp) executeTxs(ctx context.Context, txs [][]byte) ([]*abci.ExecTxResult, error) { | |||
| if app.txExecutor != nil { | |||
| return app.txExecutor(ctx, len(txs), app.finalizeBlockState.ms, func(i int, ms storetypes.MultiStore, incarnationCache map[string]any) *abci.ExecTxResult { | |||
| return app.deliverTxWithMultiStore(txs[i], i, ms, incarnationCache) | |||
| return app.txExecutor(ctx, len(txs), app.finalizeBlockState.ms, func(i int, ms storetypes.MultiStore) *abci.ExecTxResult { | |||
There was a problem hiding this comment.
txExecutor interface need to keep too.
There was a problem hiding this comment.
we just need get and set right? Do you mean keep txExecutor but pass nil?
There was a problem hiding this comment.
stm executor will pass non-nil cache.
|
Diff doesn't come from consensusParams but from auth ante handler which was fixed before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Problem: signature verification result not cache between incarnations of same tx (#565)"
This reverts commit 5a1594f.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...