Problem: cosmos-sdk 0.46 is not used

.golangci.yml

@@ -17,6 +17,12 @@ linters:
     - stylecheck
     - unconvert
 
+issues:
+  exclude-rules:
+    - text: "Use of weak random number generator"
+      linters:
+        - gosec
+
 linters-settings:
   exclude: ./pystarport/pystarport/*
   govet:

app/export.go

@@ -118,7 +118,9 @@ func (app *ChainApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs
 		feePool.CommunityPool = feePool.CommunityPool.Add(scraps...)
 		app.DistrKeeper.SetFeePool(ctx, feePool)
 
-		app.DistrKeeper.Hooks().AfterValidatorCreated(ctx, val.GetOperator())
+		if err := app.DistrKeeper.Hooks().AfterValidatorCreated(ctx, val.GetOperator()); err != nil {
+			panic(err)
+		}
 		return false
 	})
 
@@ -133,8 +135,12 @@ func (app *ChainApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs
 		if errd != nil {
 			panic(errd)
 		}
-		app.DistrKeeper.Hooks().BeforeDelegationCreated(ctx, delAddr, valAddr)
-		app.DistrKeeper.Hooks().AfterDelegationModified(ctx, delAddr, valAddr)
+		if err := app.DistrKeeper.Hooks().BeforeDelegationCreated(ctx, delAddr, valAddr); err != nil {
+			panic(err)
+		}
+		if err := app.DistrKeeper.Hooks().AfterDelegationModified(ctx, delAddr, valAddr); err != nil {
+			panic(err)
+		}
 	}
 
 	// reset context height

app/sim_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/cosmos/cosmos-sdk/simapp/helpers"
 	"github.com/cosmos/cosmos-sdk/store"
 	"github.com/cosmos/cosmos-sdk/store/prefix"
+	storetypes "github.com/cosmos/cosmos-sdk/store/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
 	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
@@ -46,8 +47,8 @@ func init() {
 }
 
 type StoreKeysPrefixes struct {
-	A        sdk.StoreKey
-	B        sdk.StoreKey
+	A        storetypes.StoreKey
+	B        storetypes.StoreKey
 	Prefixes [][]byte
 }
 

app/test_helpers.go

@@ -10,6 +10,7 @@ import (
 	"testing"
 	"time"
 
+	sdkmath "cosmossdk.io/math"
 	"github.com/CosmWasm/wasmd/x/wasm"
 	"github.com/stretchr/testify/require"
 	abci "github.com/tendermint/tendermint/abci/types"
@@ -240,7 +241,7 @@ func createIncrementalAccounts(accNum int) []sdk.AccAddress {
 }
 
 // AddTestAddrsFromPubKeys adds the addresses into the ChainApp providing only the public keys.
-func AddTestAddrsFromPubKeys(app *ChainApp, ctx sdk.Context, pubKeys []cryptotypes.PubKey, accAmt sdk.Int) {
+func AddTestAddrsFromPubKeys(app *ChainApp, ctx sdk.Context, pubKeys []cryptotypes.PubKey, accAmt sdkmath.Int) {
 	initCoins := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), accAmt))
 
 	for _, pk := range pubKeys {
@@ -250,17 +251,17 @@ func AddTestAddrsFromPubKeys(app *ChainApp, ctx sdk.Context, pubKeys []cryptotyp
 
 // AddTestAddrs constructs and returns accNum amount of accounts with an
 // initial balance of accAmt in random order
-func AddTestAddrs(app *ChainApp, ctx sdk.Context, accNum int, accAmt sdk.Int) []sdk.AccAddress {
+func AddTestAddrs(app *ChainApp, ctx sdk.Context, accNum int, accAmt sdkmath.Int) []sdk.AccAddress {
 	return addTestAddrs(app, ctx, accNum, accAmt, createRandomAccounts)
 }
 
 // AddTestAddrs constructs and returns accNum amount of accounts with an
 // initial balance of accAmt in random order
-func AddTestAddrsIncremental(app *ChainApp, ctx sdk.Context, accNum int, accAmt sdk.Int) []sdk.AccAddress {
+func AddTestAddrsIncremental(app *ChainApp, ctx sdk.Context, accNum int, accAmt sdkmath.Int) []sdk.AccAddress {
 	return addTestAddrs(app, ctx, accNum, accAmt, createIncrementalAccounts)
 }
 
-func addTestAddrs(app *ChainApp, ctx sdk.Context, accNum int, accAmt sdk.Int, strategy GenerateAccountStrategy) []sdk.AccAddress {
+func addTestAddrs(app *ChainApp, ctx sdk.Context, accNum int, accAmt sdkmath.Int, strategy GenerateAccountStrategy) []sdk.AccAddress {
 	testAddrs := strategy(accNum)
 
 	initCoins := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), accAmt))

cmd/chain-maind/app/app.go

@@ -320,7 +320,7 @@ func newApp(logger log.Logger, db dbm.DB, traceStore io.Writer, appOpts serverty
 		panic(err)
 	}
 
-	snapshotDB, err := sdk.NewLevelDB("metadata", snapshotDir)
+	snapshotDB, err := dbm.NewDB("metadata", server.GetAppDBBackend(appOpts), snapshotDir)
 	if err != nil {
 		panic(err)
 	}

config/config_test.go

@@ -11,11 +11,12 @@ import (
 	keys "github.com/cosmos/cosmos-sdk/crypto/keyring"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
+	"github.com/crypto-org-chain/chain-main/v4/app"
 	"github.com/crypto-org-chain/chain-main/v4/config"
 )
 
 func TestMnemonic(t *testing.T) {
-	kb := keys.NewInMemory()
+	kb := keys.NewInMemory(app.MakeEncodingConfig().Marshaler)
 	account, err := kb.NewAccount(
 		"croTest",
 		"point shiver hurt flight fun online hub antenna engine pave chef fantasy front interest poem accident catch load frequent praise elite pet remove used",
@@ -25,14 +26,14 @@ func TestMnemonic(t *testing.T) {
 	)
 	require.NoError(t, err)
 
-	publicKey := account.GetPubKey()
+	publicKey := account.PubKey
 	expectedPublicKey := []byte("0396bb69cbbf27c07e08c0a9d8ac2002ed75a6287a3f2e4cfe11977817ca14fad0")
 
 	expectedPublicKeyBytes := make([]byte, hex.DecodedLen(len(expectedPublicKey)))
 	_, err = hex.Decode(expectedPublicKeyBytes, expectedPublicKey)
 	require.NoError(t, err)
 
-	if !bytes.Equal(expectedPublicKeyBytes, publicKey.Bytes()) {
+	if !bytes.Equal(expectedPublicKeyBytes, publicKey.Value) {
 		t.Error("HD public key does not match to expected public key")
 	}
 }

test/coins.go

@@ -4,6 +4,7 @@ import (
 	fmt "fmt"
 	"strings"
 
+	sdkmath "cosmossdk.io/math"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
 
@@ -40,12 +41,12 @@ func (parser *FakeCoinParser) GetBaseUnit() string {
 }
 
 // FIXME: NOT IMPLEMENTED
-func (parser *FakeCoinParser) MustSprintBaseCoin(baseCoin sdk.Int, denom string) string {
+func (parser *FakeCoinParser) MustSprintBaseCoin(baseCoin sdkmath.Int, denom string) string {
 	return ""
 }
 
 // FIXME: NOT IMPLEMENTED
-func (parser *FakeCoinParser) SprintBaseCoin(baseCoin sdk.Int, denom string) (string, error) {
+func (parser *FakeCoinParser) SprintBaseCoin(baseCoin sdkmath.Int, denom string) (string, error) {
 	return "", nil
 }
 

x/chainmain/client/cli/testnet.go

@@ -12,6 +12,7 @@ import (
 	"path/filepath"
 	"time"
 
+	sdkmath "cosmossdk.io/math"
 	crypto "github.com/cosmos/cosmos-sdk/crypto/types"
 	"github.com/spf13/cobra"
 	tmconfig "github.com/tendermint/tendermint/config"
@@ -267,7 +268,8 @@ func InitTestnet(
 			_ = os.RemoveAll(outputDir)
 			return saveErr
 		}
-		addr, err := keyInfo.GetAddress()
+		var addr sdk.AccAddress
+		addr, err = keyInfo.GetAddress()
 		if err != nil {
 			_ = os.RemoveAll(outputDir)
 			return err
@@ -562,10 +564,10 @@ func parseStakingCoin(coins sdk.Coins, stakingAmount string) (sdk.Coin, error) {
 }
 
 // return half amount of coins
-func halfCoins(coins sdk.Coins) sdk.Int {
-	amount := sdk.ZeroInt()
+func halfCoins(coins sdk.Coins) sdkmath.Int {
+	amount := sdkmath.ZeroInt()
 	for _, coin := range coins {
-		amount = amount.Add(coin.Amount.Quo(sdk.NewInt(2)))
+		amount = amount.Add(coin.Amount.Quo(sdkmath.NewInt(2)))
 	}
 	return amount
 }

x/nft/client/cli/cli_test.go

@@ -29,16 +29,18 @@ type IntegrationTestSuite struct {
 }
 
 func (s *IntegrationTestSuite) SetupSuite() {
+	var err error
 	s.T().Log("setting up integration test suite")
 
 	cfg := network.DefaultConfig()
 	cfg.AppConstructor = nfttestutil.GetApp
 	cfg.NumValidators = 2
 
 	s.cfg = cfg
-	s.network = network.New(s.T(), cfg)
+	s.network, err = network.New(s.T(), s.T().TempDir(), cfg)
+	s.Require().NoError(err)
 
-	_, err := s.network.WaitForHeight(1)
+	_, err = s.network.WaitForHeight(1)
 	s.Require().NoError(err)
 }
 

x/nft/client/testutil/test_helpers.go

@@ -19,8 +19,8 @@ import (
 	"github.com/crypto-org-chain/chain-main/v4/app"
 	nftcli "github.com/crypto-org-chain/chain-main/v4/x/nft/client/cli"
 
+	pruningtypes "github.com/cosmos/cosmos-sdk/pruning/types"
 	servertypes "github.com/cosmos/cosmos-sdk/server/types"
-	storetypes "github.com/cosmos/cosmos-sdk/store/types"
 	dbm "github.com/tendermint/tm-db"
 )
 
@@ -31,7 +31,7 @@ func GetApp(val network.Validator) servertypes.Application {
 		wasm.EnableAllProposals,
 		simapp.EmptyAppOptions{},
 		nil,
-		baseapp.SetPruning(storetypes.NewPruningOptionsFromString(val.AppConfig.Pruning)),
+		baseapp.SetPruning(pruningtypes.NewPruningOptionsFromString(val.AppConfig.Pruning)),
 		baseapp.SetMinGasPrices(val.AppConfig.MinGasPrices),
 	)
 }

x/nft/keeper/keeper_test.go

@@ -211,8 +211,8 @@ func CreateTestAddrs(numAddrs int) []sdk.AccAddress {
 		numString := strconv.Itoa(i)
 		buffer.WriteString("A58856F0FD53BF058B4909A21AEC019107BA6") // base address string
 
-		buffer.WriteString(numString)                    // adding on final two digits to make addresses unique
-		res, _ := sdk.AccAddressFromHex(buffer.String()) // nolint: errcheck
+		buffer.WriteString(numString)                          // adding on final two digits to make addresses unique
+		res, _ := sdk.AccAddressFromHexUnsafe(buffer.String()) // nolint: errcheck
 		bech := res.String()
 		addresses = append(addresses, testAddr(buffer.String(), bech))
 		buffer.Reset()
@@ -223,7 +223,7 @@ func CreateTestAddrs(numAddrs int) []sdk.AccAddress {
 
 // for incode address generation
 func testAddr(addr string, bech string) sdk.AccAddress {
-	res, err := sdk.AccAddressFromHex(addr)
+	res, err := sdk.AccAddressFromHexUnsafe(addr)
 	if err != nil {
 		panic(err)
 	}

x/nft/types/common_test.go

@@ -32,8 +32,8 @@ func CreateTestAddrs(numAddrs int) []sdk.AccAddress {
 		numString := strconv.Itoa(i)
 		buffer.WriteString("A58856F0FD53BF058B4909A21AEC019107BA6") // base address string
 
-		buffer.WriteString(numString)                    // adding on final two digits to make addresses unique
-		res, _ := sdk.AccAddressFromHex(buffer.String()) // nolint: errcheck
+		buffer.WriteString(numString)                          // adding on final two digits to make addresses unique
+		res, _ := sdk.AccAddressFromHexUnsafe(buffer.String()) // nolint: errcheck
 		bech := res.String()
 		addresses = append(addresses, testAddr(buffer.String(), bech))
 		buffer.Reset()
@@ -43,7 +43,7 @@ func CreateTestAddrs(numAddrs int) []sdk.AccAddress {
 
 // for incode address generation
 func testAddr(addr string, bech string) sdk.AccAddress {
-	res, err := sdk.AccAddressFromHex(addr)
+	res, err := sdk.AccAddressFromHexUnsafe(addr)
 	if err != nil {
 		panic(err)
 	}