fix(events): permit JFR Event Types without label attributes (backport #804) #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit ea87588)
|
This PR/issue depends on: |
|
/build_test |
|
Workflow started at 2/13/2025, 4:04:43 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #803
Depends on cryostatio/cryostat-core#507
Description of the change:
JFR events do not necessarily have the
labelattribute, which in the JMC API is calledname. The OpenJDK built-in events all happen to have this attribute, but custom application or framework events may not, and notably GraalVM has at least one event type (EveryChunkPeriodEvents) which has no label.Motivation for the change:
Unlabelled JFR events would cause an NPE on
/api/v4/targets/{id}/eventsquery before this.How to manually test:
./mvnw -o clean package./smoketest.bash -O -t quarkus-nativejmxquarkustarget. Ensure that Event Types table populates. Ensure that a recording can be started, archived, automated-analysis'd, etc.This is an automatic backport of pull request #804 done by [Mergify](https://mergify.com).