Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): Fix notification String constants #785

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Josh-Matsuoka
Copy link
Contributor

Fixes: #761

Description of the change:

Fixes the notification category for ArchiveRecordingFailure and GrafanaUploadFailure to bring them in line with what the web frontend expects.

How to manually test:

  1. Run cryostat via ./mvnw quarkus:dev or smoketest
  2. Fail to archive a recording (Can induce this by throwing an exception at the start of the try/catch in LongRunningRequestGenerator.java (line 71 for archive, 90, 107 for grafana))
  3. Observe that the notifications are emitted.

@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 1/27/2025, 12:51:55 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/12995118348

@andrewazores andrewazores merged commit e9b5831 into cryostatio:main Jan 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Recording archive failure notification title mismatch
2 participants