Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grafana): add redirecting endpoint for archived recordings #324

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix(grafana): add redirecting endpoint for archived recordings #324

merged 1 commit into from
Apr 15, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Based on #315

Description of the change:

Adds a missing endpoint. This implementation mirrors the other similar one in that it simply redirects the client to a new API endpoint.

Motivation for the change:

This re-enables the "View in Grafana" action in the UI for the "Recordings > Archived" and "Archives > All Targets" views.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores andrewazores marked this pull request as draft March 11, 2024 15:41
@andrewazores andrewazores mentioned this pull request Mar 11, 2024
Merged
@andrewazores andrewazores force-pushed the archived-recordings-grafana branch from 715f21d to 83ae499 Compare March 15, 2024 15:39
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@andrewazores andrewazores marked this pull request as ready for review March 15, 2024 15:40
@andrewazores andrewazores requested a review from a team as a code owner March 20, 2024 17:26
@andrewazores andrewazores mentioned this pull request Mar 20, 2024
Merged
14 tasks
@andrewazores andrewazores force-pushed the archived-recordings-grafana branch from 83ae499 to 6856744 Compare March 20, 2024 17:55
@andrewazores andrewazores force-pushed the archived-recordings-grafana branch from 6856744 to 6a5dd85 Compare March 22, 2024 13:34
@andrewazores andrewazores removed the request for review from a team March 22, 2024 18:35
@andrewazores andrewazores force-pushed the archived-recordings-grafana branch from 6a5dd85 to 84c63df Compare April 13, 2024 03:36
@andrewazores andrewazores force-pushed the archived-recordings-grafana branch from 84c63df to 9e43bb5 Compare April 13, 2024 03:47
@andrewazores
Copy link
Member Author

@aali309 ping

@andrewazores andrewazores mentioned this pull request Apr 13, 2024
Merged
12 tasks
aali309
aali309 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 36922a2 into cryostatio:graphql Apr 15, 2024
7 checks passed
@andrewazores andrewazores deleted the archived-recordings-grafana branch April 15, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
fix safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @aali309