avoid NoResultException if 'archive on stop' recording is already del…

…eted. may still occur in a race condition, but is harmless - just log noise
cryostatio · Apr 2, 2024 · a4c0ae8 · a4c0ae8
1 parent 0bc5399
commit a4c0ae8
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/main/java/io/cryostat/recordings/RecordingHelper.java b/src/main/java/io/cryostat/recordings/RecordingHelper.java
@@ -1101,10 +1101,13 @@ static class StopRecordingJob implements Job {
         public void execute(JobExecutionContext ctx) throws JobExecutionException {
             var jobDataMap = ctx.getJobDetail().getJobDataMap();
             try {
-                ActiveRecording recording =
+                Optional<ActiveRecording> recording =
                         ActiveRecording.find("id", (Long) jobDataMap.get("recordingId"))
-                                .singleResult();
-                recordingHelper.stopRecording(recording, (Boolean) jobDataMap.get("archive"));
+                                .singleResultOptional();
+                if (recording.isPresent()) {
+                    recordingHelper.stopRecording(
+                            recording.get(), (Boolean) jobDataMap.get("archive"));
+                }
             } catch (Exception e) {
                 throw new JobExecutionException(e);
             }