refactor, move persistence interactions out of worker thread executio…

…n and onto persistent context execution
cryostatio · Apr 2, 2024 · 6bc061f · 6bc061f
1 parent 15cf436
commit 6bc061f
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/src/main/java/io/cryostat/recordings/RecordingHelper.java b/src/main/java/io/cryostat/recordings/RecordingHelper.java
@@ -470,19 +470,21 @@ public ActiveRecording stopRecording(ActiveRecording recording) throws Exception
     @Blocking
     @Transactional
     public ActiveRecording deleteRecording(ActiveRecording recording) {
-        return connectionManager.executeConnectedTask(
-                recording.target,
-                conn -> {
-                    var desc = getDescriptorById(conn, recording.remoteId);
-                    if (desc.isEmpty()) {
-                        throw new NotFoundException();
-                    }
-                    conn.getService().close(desc.get());
-                    recording.target.activeRecordings.remove(recording);
-                    recording.target.persist();
-                    recording.delete();
-                    return recording;
-                });
+        var closed =
+                connectionManager.executeConnectedTask(
+                        recording.target,
+                        conn -> {
+                            var desc = getDescriptorById(conn, recording.remoteId);
+                            if (desc.isEmpty()) {
+                                throw new NotFoundException();
+                            }
+                            conn.getService().close(desc.get());
+                            return recording;
+                        });
+        closed.target.activeRecordings.remove(recording);
+        closed.target.persist();
+        closed.delete();
+        return closed;
     }
 
     public LinkedRecordingDescriptor toExternalForm(ActiveRecording recording) {