chore(mbeans): use own-defined type to replace java.lang.management.MemoryUsage #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
chore
7 tasks
To run smoketest: |
aali309
approved these changes
Feb 29, 2024
andrewazores
force-pushed
the
memoryusage-bean
branch
from
b542838 to
b0513fe
Compare
|
This PR/issue depends on:
|
To run smoketest: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356
Depends on #357
Workaround related to cryostatio/cryostat#307 . Quarkus fails to index
java.lang.management.MemoryUsageand this causes the GraphQL schema validation to fail, since the type is found in the generated schema but is not indexed. Creating this type separately and indexing it with #357 works and is a less leaky abstraction.