Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewazores committed Mar 7, 2025
1 parent 1d2f727 commit d4adb87
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 15 deletions.
7 changes: 1 addition & 6 deletions src/main/java/io/cryostat/agent/CryostatClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -510,12 +510,7 @@ private HttpResponse assertOkStatus(HttpRequestBase req, HttpResponse res) {
return res;
}

@SuppressFBWarnings(
value = {
"URF_UNREAD_FIELD",
"UWF_UNWRITTEN_FIELD",
"UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"
})
@SuppressFBWarnings("UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD")
public static class StoredCredential {

public int id;
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/io/cryostat/agent/FlightRecorderHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public Optional<Recording> getRecording(long id) {
return getRecordings(r -> r.getId() == id).stream().findFirst();
}

@SuppressFBWarnings(value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
@SuppressFBWarnings("EI_EXPOSE_REP")
public static class TemplatedRecording {
private final ConfigurationInfo configuration;
private final Recording recording;
Expand Down Expand Up @@ -175,7 +175,6 @@ public TemplateType getType() {
}
}

@SuppressFBWarnings(value = "URF_UNREAD_FIELD")
public static class RecordingInfo {

public final long id;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/cryostat/agent/harvest/Harvester.java
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public class Harvester implements FlightRecorderListener {
private Future<?> task;
private boolean running;

@SuppressFBWarnings(value = {"EI_EXPOSE_REP2", "CT_CONSTRUCTOR_THROW"})
@SuppressFBWarnings("EI_EXPOSE_REP2")
public Harvester(
ScheduledExecutorService executor,
ScheduledExecutorService workerPool,
Expand Down
4 changes: 1 addition & 3 deletions src/main/java/io/cryostat/agent/model/ServerHealth.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

@SuppressFBWarnings(value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
@SuppressFBWarnings("EI_EXPOSE_REP")
public class ServerHealth {

private String cryostatVersion;
Expand Down Expand Up @@ -52,7 +52,6 @@ public BuildInfo buildInfo() {
return build;
}

@SuppressFBWarnings(value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
public static class BuildInfo {
private GitInfo git;

Expand All @@ -71,7 +70,6 @@ public GitInfo git() {
}
}

@SuppressFBWarnings(value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
public static class GitInfo {
private String hash;

Expand Down
3 changes: 0 additions & 3 deletions src/main/java/io/cryostat/agent/remote/EventTypesContext.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

import com.fasterxml.jackson.databind.ObjectMapper;
import com.sun.net.httpserver.HttpExchange;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import jdk.jfr.EventType;
import jdk.jfr.FlightRecorder;
import jdk.jfr.SettingDescriptor;
Expand Down Expand Up @@ -93,7 +92,6 @@ private List<EventInfo> getEventTypes() {
.collect(Collectors.toList());
}

@SuppressFBWarnings(value = "URF_UNREAD_FIELD")
private static class EventInfo {

public final String name;
Expand All @@ -110,7 +108,6 @@ private static class EventInfo {
}
}

@SuppressFBWarnings(value = "URF_UNREAD_FIELD")
private static class SettingInfo {

public final String name;
Expand Down

0 comments on commit d4adb87

Please sign in to comment.