-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to update screenshots #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update API - Update ScreenshotsFeature Add new methods to update screenshots to CrowdinSDK Add ability to enter screenshot name when capture from floating button. Add message to logs with result of screenshot capturing: new or updated.
SwiftLint found issues
Generated by 🚫 Danger Swift against 56ba1bb |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 61.17% 60.49% -0.67%
==========================================
Files 121 122 +1
Lines 4377 4426 +49
==========================================
Hits 2677 2677
- Misses 1700 1749 +49 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
andrii-bodnar
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to update screenshots:
Add new methods to update screenshots to CrowdinSDK
Add ability to enter screenshot name when capture from floating button.
Add message to logs with result of screenshot capturing: new or updated.
Update podfile.lock for objc example and tests projects.
Update podfile to fix build errors for example project.