Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Watson translate engine #311

Conversation

andreichirila0712
Copy link
Contributor

Summary

This PR removes the Watson translation engine as it's no longer supported/needed.

Changes

  • Deleted the WATSON enum constant from Type.java.
  • Removed the file associated with the Watson translation engine.
  • Fixed a typo in getMtTest method name.

Testing

  • No new tests were added since this PR removes an unsupported feature.

* Deleted the WATSON enum constant from Type.java.
* Removed the file associated with the Watson translation engine.
* Fixed a typo in getMtTest method name.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (5ab9f0c) to head (928629f).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #311   +/-   ##
=========================================
  Coverage     94.14%   94.14%           
  Complexity      810      810           
=========================================
  Files           190      190           
  Lines          2729     2729           
  Branches         54       54           
=========================================
  Hits           2569     2569           
  Misses          134      134           
  Partials         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreichirila0712 thank you!

@andrii-bodnar andrii-bodnar merged commit 47b3128 into crowdin:master Jan 30, 2025
2 checks passed
@andrii-bodnar andrii-bodnar linked an issue Jan 30, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Machine Translation: remove Watson (IBM) Translate engine
3 participants