-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update rustix
to fix the enable_raw_mode()
error on WSL/Android
#926
Conversation
Being explicit about versions like this means that when cargo does dependency resolution, it will not resolve a set of versions that does not work. Apps that don't specifically lock the rustix version can just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TIL about this, it makes total sense. Thanks for the excellent explanation! |
@TimonPost this is a simple version bump and is pretty safe to merge. |
Gently pinging @TimonPost this PR so Yazi could be used on Android again. Thanks! |
This is not a blocker for building anything downstream. Specifying That said, I'm going to merge this. |
Fixes #912
Related upstream PR: bytecodealliance/rustix#1147
Should we limit
rustix
to just the mirror version, similar to whatlibc
does, so that upstream fixes will automatically apply in the future?crossterm/Cargo.toml
Line 77 in b056370
Also if possible, could we release a patch version of
crossterm
that includes this fix?