Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deterministic PRNG where possible. #34

Merged
merged 31 commits into from
Aug 9, 2024
Merged

Conversation

J08nY
Copy link
Member

@J08nY J08nY commented Aug 5, 2024

This adds support for initializing the libraries with a determinisitic PRNG as well as making the test suites more deterministic based on a seed given on the command-line. Similarly, it makes the card test suites deterministic, even though the card RNGs cannot be made so.

The following libraries do not currently behave deterministically:

  • wolfCrypt

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 51.21951% with 40 lines in your changes missing coverage. Please review.

Project coverage is 53.98%. Comparing base (88c9d01) to head (be605a2).

Files Patch % Lines
...va/cz/crcs/ectester/reader/test/CardTestSuite.java 10.00% 15 Missing and 3 partials ⚠️
...c/main/java/cz/crcs/ectester/common/util/Util.java 20.00% 6 Missing and 2 partials ⚠️
...n/java/cz/crcs/ectester/reader/ECTesterReader.java 68.00% 3 Missing and 5 partials ⚠️
...z/crcs/ectester/reader/test/CardCofactorSuite.java 20.00% 4 Missing ⚠️
.../crcs/ectester/reader/test/CardCompositeSuite.java 50.00% 1 Missing ⚠️
...a/cz/crcs/ectester/reader/test/CardWrongSuite.java 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (88c9d01) and HEAD (be605a2). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (88c9d01) HEAD (be605a2)
4 2
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
- Coverage     61.28%   53.98%   -7.31%     
+ Complexity     1308      816     -492     
============================================
  Files           133       77      -56     
  Lines          9212     6443    -2769     
  Branches       1261      924     -337     
============================================
- Hits           5646     3478    -2168     
+ Misses         2983     2567     -416     
+ Partials        583      398     -185     
Components Coverage Δ
Applet 70.27% <ø> (+0.43%) ⬆️
Common 45.40% <20.00%> (-12.73%) ⬇️
Reader 55.44% <55.55%> (+4.99%) ⬆️
Standalone ∅ <ø> (∅)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J08nY J08nY marked this pull request as ready for review August 7, 2024 19:18
@J08nY J08nY changed the title Feat/deterministic prng Support deterministic PRNG where possible. Aug 8, 2024
@J08nY J08nY merged commit 65ddb49 into master Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants