Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center boxes within the card. #103

Closed
wants to merge 2 commits into from
Closed

Conversation

nivthefox
Copy link

Fixes #102 .

@crobi
Copy link
Owner

crobi commented Nov 9, 2017

Two comments:

  • This is subjective, some people might like left-aligned boxes (all other content is left-aligned)
  • This is a breaking change, the alignment needs to be a new parameter, e.g., boxes | [count] | [size] | [alignment]

@nivthefox
Copy link
Author

Interesting! I didn't even know size was a parameter. I'll update the PR to make alignment a feature choice today.

@nivthefox
Copy link
Author

Closing this. Will reopen a more appropriate PR.

@nivthefox nivthefox closed this Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants