fix: use lspconfig.util._available_servers #14
Conversation
lua/dotfyle_metadata/extras/lsp.lua
Outdated
| @@ -7,7 +7,7 @@ return function() | |||
| return {} | |||
| end | |||
|
|
|||
| local servers = lspconfig.util.available_servers() | |||
| local servers = lspconfig.util._available_servers() | |||
There was a problem hiding this comment.
Hey thanks for the PR!
Would you be able to keep the previous function call and do a check for the new function?
Since this change is very recent (2 days ago from today) not many users would've updated the lspconfig plugin (like myself).
I think it's best to still keep the old function for some time before we rename it completely to the new _available_servers.
I'm thinking like the following conditional pseudocode:
- If
_available_serversis not nil then call it - Otherwise, call
available_servers
There was a problem hiding this comment.
I'm getting an error where _available_servers is not available, If I'm in the older version of lspconfig.
I think it's best to compare if the function itself is defined instead of calling the function.
So check lspconfig.util._available_servers ~= nil (without the braces ())
Then servers = lspconfig.util._available_servers() (call the function) otherwise servers = lspconfig.util.available_servers()
lua/dotfyle_metadata/extras/lsp.lua
Outdated
| @@ -7,7 +7,7 @@ return function() | |||
| return {} | |||
| end | |||
|
|
|||
| local servers = lspconfig.util.available_servers() | |||
| local servers = lspconfig.util._available_servers() | |||
There was a problem hiding this comment.
I'm getting an error where _available_servers is not available, If I'm in the older version of lspconfig.
I think it's best to compare if the function itself is defined instead of calling the function.
So check lspconfig.util._available_servers ~= nil (without the braces ())
Then servers = lspconfig.util._available_servers() (call the function) otherwise servers = lspconfig.util.available_servers()
mimikun
force-pushed
the
fix/lspconfig
branch
from
c177f80 to
6652a77
Compare
|
I've been busy and haven't been able to comment. |
|
This change was reverted in neovim/nvim-lspconfig#3589. |
|
I think it's fine to leave as it is. Not sure if they will change their minds to go back to using the |
The
lspconfig.util.available_servershas become a private function and it no longer works.This PR will fix this.
ref: neovim/nvim-lspconfig@e118ce5
ref: folke/neoconf.nvim#105