Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (e2e) : add step for setting persistent-volume-size config option (#4186) #4623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohanKanojia
Copy link
Contributor

Description

Fixes: #4186

Add step for persistent-volume-size config option in story_microshift.feature

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

Add integration test to verify this scenario:

  • Given
    • User sets disk-size to 41
    • User sets persistent-volume-size to 20
  • When
    • User starts CRC cluster with microshfit preset
  • Then
    • persistent volume size is equal to (diskSize - (lvmSize +1))

Testing

I've only verified that the test is passing on Linux, MacOS, and Windows.

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

Copy link

openshift-ci bot commented Feb 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@anjannath
Copy link
Member

/test e2e-crc

@anjannath
Copy link
Member

/test e2e-microshift-crc

@rohanKanojia
Copy link
Contributor Author

I'm not sure whether the failure in integration tests has anything to do with the changes added in this pull request:

  * could not run steps: step integration-crc failed: could not lazily evaluate deferred parameter "RELEASE_IMAGE_LATEST": image stream "release" has no tag "latest" in spec or status 
�[36mINFO�[0m[2025-02-17T07:16:50Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:executing_test:executing_multi_stage_test' 

It seems the e2e pipeline failed in the initialization step.

Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ion (crc-org#4186)

Add step for `persistent-volume-size` config option in story_microshift.feature

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

openshift-ci bot commented Feb 18, 2025

@rohanKanojia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc e505f6a link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rohanKanojia
Copy link
Contributor Author

/test e2e-microshift-crc

@rohanKanojia
Copy link
Contributor Author

I can see in microshift e2e logs that added steps are passing:

  �[1;37mBackground:�[0m
    �[32mGiven�[0m �[32msetting config property "preset" to value "microshift" succeeds�[0m                                                                                      �[1;30m# testsuite.go:933 -> github.com/crc-org/crc/v2/test/e2e/testsuite.SetConfigPropertyToValueSucceedsOrFails�[0m
    �[32mAnd�[0m �[32msetting config property "disk-size" to value "32" succeeds�[0m                                                                                             �[1;30m# testsuite.go:933 -> github.com/crc-org/crc/v2/test/e2e/testsuite.SetConfigPropertyToValueSucceedsOrFails�[0m
    �[32mAnd�[0m �[32msetting config property "persistent-volume-size" to value "16" succeeds�[0m                                                                                �[1;30m# testsuite.go:933 -> github.com/crc-org/crc/v2/test/e2e/testsuite.SetConfigPropertyToValueSucceedsOrFails�[0m
    �[32mAnd�[0m �[32mensuring network mode user�[0m                                                                                                                             �[1;30m# testsuite.go:1056 -> github.com/crc-org/crc/v2/test/e2e/testsuite.EnsureUserNetworkmode�[0m
    �[32mAnd�[0m �[32mexecuting single crc setup command succeeds�[0m                                                                                                            �[1;30m# testsuite.go:959 -> github.com/crc-org/crc/v2/test/e2e/testsuite.ExecuteSingleCommandWithExpectedExitStatus�[0m
    �[32mAnd�[0m �[32mstarting CRC with default bundle succeeds�[0m                                                                                                              �[1;30m# testsuite.go:780 -> github.com/crc-org/crc/v2/test/e2e/testsuite.StartCRCWithDefaultBundleSucceedsOrFails�[0m
    �[32mAnd�[0m �[32mensuring oc command is available�[0m                                                                                                                       �[1;30m# testsuite.go:911 -> github.com/crc-org/crc/v2/test/e2e/testsuite.EnsureOCCommandIsAvailable�[0m
    �[32mAnd�[0m �[32mensuring microshift cluster is fully operational�[0m                                                                                                       �[1;30m# testsuite.go:1085 -> github.com/crc-org/crc/v2/test/e2e/testsuite.EnsureMicroshiftClusterIsOperational�[0m
    �[32mAnd�[0m �[32mexecuting "crc status" succeeds�[0m                                                                                                                        �[1;30m# shell.go:245 -> github.com/crc-org/crc/v2/test/extended/util.ExecuteCommandSucceedsOrFails�[0m
    �[32mAnd�[0m �[32mstdout should contain "Persistent Volume Usage:"�[0m                                                                                                       �[1;30m# shell.go:301 -> github.com/crc-org/crc/v2/test/extended/util.CommandReturnShouldContain�[0m
    �[32mAnd�[0m �[32mpersistent volume of size "16"GB exists�[0m                                                                                                                �[1;30m# testsuite.go:1112 -> github.com/crc-org/crc/v2/test/e2e/testsuite.EnsureVMPartitionSizeCorrect�[0m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test for persistent-volume-size config option
2 participants