test (e2e) : add more assertions to verify crc status output

[rohanKanojia]

Description

⚠️ This test is expected to fail on main branch, it should be merged after #4603

Add stricter assertions to verify output of crc status.

We only verify that the CRC status output contains the keyword Running or Stopped, depending on the cluster state. However, we should also verify other attributes, such as diskSize, ramsSize, openshiftStatus, cacheDir, etc.

Relates to: PR #4603

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Proposed changes

Add another step in basic test scenario to verify output of crc status -ojson. Parse JSON output into a map and verify that values are as expected or within allowed limit.

Testing

I just verified that Basic scenario E2E test is passing when #4603 is applied.

Contribution Checklist

• I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Which platform have you tested the code changes on?
  • Linux
  • Windows
  • MacOS

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adrianriobo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rohanKanojia]

E2E test failure is expected as it captures the failure reported in #4603

  �[31mScenario: CRC start usecase�[0m �[1;30m# test/e2e/features/basic.feature:32�[0m
    �[31mAnd checking the CRC status JSON output is valid�[0m �[1;30m# test/e2e/features/basic.feature:46�[0m
      �[31mError: �[0m�[1;31mfailure in asserting 'ramSize' field of crc status json output, expected less than or equal to 11274289152 bytes, actual : 32680947712 bytes�[0m

Now that #4603 is merged it should pass after rebasing this PR.

[praveenkumar]

why those changes?

[rohanKanojia]

I'm sorry. It looks like I forgot to uncomment it after testing.

[rohanKanojia]

I think I lost the changes while pushing from another machine. I'm seeing outdated version of the changes.

[rohanKanojia]

I've updated it. I think it should be okay now.

[openshift-ci]

@rohanKanojia: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	40d9c08	link	false	/test security
ci/prow/integration-crc	40d9c08	link	true	/test integration-crc
ci/prow/e2e-crc	40d9c08	link	true	/test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[praveenkumar]

/assign @adrianriobo
/assign @albfan