Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GH action to build binary SPC #184

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Conversation

crazywhalecc
Copy link
Owner

It fixes #179 .
Related PR is #183 .

@crazywhalecc crazywhalecc added new feature New feature or request kind/workflow Issues related to workflow or environment need test This PR has not been tested yet, cannot merge now labels Sep 13, 2023
.github/workflows/release-build.yml Show resolved Hide resolved
.github/workflows/release-build.yml Outdated Show resolved Hide resolved
@dunglas
Copy link
Contributor

dunglas commented Sep 13, 2023

That would be great to also publish in GitHub releases compiled versions of the SAPIs with most (all) supported PHP extensions. This would allow CIs and scripts to just download the latest release instead of compiling it. For instance if we could download an always up-to-date version of libphp from GitHub, this would dramatically speedup the builds of FrankenPHP. Currently, building libphp again and again takes ~30 minutes: https://github.com/dunglas/frankenphp/actions/runs/6178375726/job/16771499374

@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Sep 14, 2023

@dunglas I think it could be done by creating a new workflow for automatically building libphp in the Official Fork repository, because many people are forking the project and then build it manually. If there are too many irrelevant Actions, it may be confusing.

@dunglas
Copy link
Contributor

dunglas commented Sep 14, 2023

What's the official fork? I missed that!

@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Sep 14, 2023

What's the official fork? I missed that!

@dunglas I mentioned it in the doc: https://static-php-cli.zhamao.me/en/guide/action-build.html , repo: https://github.com/zhamao-robot/static-php-cli

But it's currently manually triggered and it has not been maintained recently. The reason I haven't updated is that there have been a lot of recent changes, and the built binary is more like a demo than a production-ready state (because the included extensions are needed for my own previous web projects). But tbh there is no suitable solution to "officially" build which common extensions included.

@crazywhalecc crazywhalecc marked this pull request as draft September 15, 2023 15:28
@stloyd
Copy link
Contributor

stloyd commented Sep 16, 2023

@crazywhalecc is there anything missing to get this merged and be tested in the wild?

I would love to get feedback and improve if needed rather than wait 😉

@crazywhalecc crazywhalecc marked this pull request as ready for review September 16, 2023 07:15
@crazywhalecc crazywhalecc removed the need test This PR has not been tested yet, cannot merge now label Sep 16, 2023
@crazywhalecc crazywhalecc merged commit 824748c into main Sep 16, 2023
@crazywhalecc crazywhalecc deleted the gh-release-build-spc branch September 16, 2023 07:15
@stloyd
Copy link
Contributor

stloyd commented Sep 16, 2023

Great, thank you @crazywhalecc ! Just one more thing :) Can you trigger a run of that workflow? So we can download the pre-built binary & test it? Or do you want to wait for the release of 2.0?
https://github.com/crazywhalecc/static-php-cli/actions/workflows/release-build.yml

@crazywhalecc
Copy link
Owner Author

@stloyd undoubted https://github.com/crazywhalecc/static-php-cli/actions/runs/6206145910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/workflow Issues related to workflow or environment new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite of "deploy" command to use new phar generation
3 participants