Add "CrateDB" utility plugin #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Dec 7, 2023
amotl
force-pushed
the
cratedb
branch
2 times, most recently
from
af70290 to
d380a77
Compare
amotl
requested review from
ckurze
and removed request for
matriv and
matkuliak
matriv
reviewed
Dec 8, 2023
amotl
commented
Dec 8, 2023
| image: crate:latest | ||
| ports: | ||
| '4200': 4200/tcp | ||
| '5433': 5432/tcp |
There was a problem hiding this comment.
I discovered elsewhere that 5433 might be used for PostgreSQL/SSL within Meltano testing infra. Do you have a suggestion to use a different port? Maybe 6432?
There was a problem hiding this comment.
Anything would work, don't know, 15432 is also an option, maybe someone else has a better suggestion.
matriv
approved these changes
Dec 8, 2023
| image: crate:latest | ||
| ports: | ||
| '4200': 4200/tcp | ||
| '5433': 5432/tcp |
There was a problem hiding this comment.
Anything would work, don't know, 15432 is also an option, maybe someone else has a better suggestion.
seut
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This patch adds CrateDB to the Meltano Utilities page at https://hub.meltano.com/utilities/.
Preview