Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update license file #119

Merged
merged 1 commit into from
Feb 21, 2025
Merged

update license file #119

merged 1 commit into from
Feb 21, 2025

Conversation

bollwyvl
Copy link
Contributor

Congratulations on 0.23.0! 🎉

While working this downstream on conda-forge, noted that the pyproject.toml references COPYING as the license-file, but the repo's file is LICENSE. This PR updates it to align with the file that exists.

A broader note, related to #88: has the abi3 route been considered for this package? While I'm not qualified to assess whether this would be a good thing from a performance perspective, much less propose the changes, as a repackager, this would slash the number of CPython builds by a large margin. PyPy and 3.13t would no doubt need special consideration.

@Julian
Copy link
Member

Julian commented Feb 21, 2025

Thanks, sloppy copy pasting clearly, will merge after CI and send out a new release

A broader note, related to #88: has the abi3 route been considered for this package? While I'm not qualified to assess whether this would be a good thing from a performance perspective, much less propose the changes, as a repackager, this would slash the number of CPython builds by a large margin. PyPy and 3.13t would no doubt need special consideration.

I'm not sure either honestly without research, I'm sure I've looked into it at some point but I'd have to do some work again to understand the implications...

@Julian Julian merged commit ba862f6 into crate-py:main Feb 21, 2025
38 checks passed
@bollwyvl bollwyvl deleted the patch-1 branch February 21, 2025 23:09
@bollwyvl
Copy link
Contributor Author

Shipped 0.23.1 on conda-forge, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants