Fixed orders not completing with a processing transaction

craftcms · Dec 6, 2023 · 1242f50 · 1242f50
1 parent 4f56359
commit 1242f50
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 - Fixed a bug where sales weren’t respecting site element statuses. ([#3328](https://github.com/craftcms/commerce/issues/3328))
 - Fixed a bug where soft-deleted order statuses and line item statuses would not being restored when applying project config changes. ([#3164](https://github.com/craftcms/commerce/issues/3164))
 - Fixed a bug where carts weren’t being restored after logging in.
+- Fixed a bug where orders with a processing transaction weren’t being completed.
 
 ## 4.3.2 - 2023-10-31
 

diff --git a/src/services/Payments.php b/src/services/Payments.php
@@ -305,7 +305,7 @@ public function processPayment(Order $order, BasePaymentForm $form, ?string &$re
                 return;
             }
 
-            if ($transaction->status !== TransactionRecord::STATUS_SUCCESS) {
+            if (!in_array($transaction->status, [TransactionRecord::STATUS_SUCCESS, TransactionRecord::STATUS_PROCESSING])) {
                 throw new PaymentException($transaction->message);
             }
-Original file line number
+Diff line change
@@ Expand Up @@
                     return;
                 }
-                if ($transaction->status !== TransactionRecord::STATUS_SUCCESS) {
+                if (!in_array($transaction->status, [TransactionRecord::STATUS_SUCCESS, TransactionRecord::STATUS_PROCESSING])) {
                     throw new PaymentException($transaction->message);
                 }
@@ Expand Down @@