Add the possiblity to use boolean expression for path animations #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manuel83
pushed a commit
that referenced
this pull request
Feb 27, 2022
Added logfile download via journalctl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Manuel,
I tried to implement an improve path animation setup that allows to use boolean expression for the animation condition of the pathes.
It's functionnal on my side but i think a little bit more testing is needed. It's seems that sometimes, 2 path are deleted when i'm using backspace. Don't think it's due to these changes.
TODO : i'm using eval function that is unsafe, perhaps it's not a security issue in craftbeer pi context ?
==> Some boolean evaluator code snippets exists and can be implemented if it's problematic
NOTA : I added an export of my config in the repo