Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable item ordering options #157

Open
wants to merge 1 commit into
base: 1.18
Choose a base branch
from
Open

Conversation

dvdkon
Copy link

@dvdkon dvdkon commented Nov 27, 2022

1.18 version of #156

@moderngamer327
Copy link

Is there any plans to still add this feature to 1.18?

@ABruel
Copy link

ABruel commented Sep 1, 2023

@moderngamer327 it has #156. But you'll need to build it yourself since the developer apparently is happy with his weird sorting preferences and is unwilling to merge these changes.

@moderngamer327
Copy link

@ABruel I actually did try to build it but it wouldn’t work. Something called Jackson-Core has updated to Java 19 but if you build it with Java 19 it can’t be used in 1.18

@ABruel
Copy link

ABruel commented Sep 2, 2023

@moderngamer327 sorry, your initial comment being here confused me. This PR is the 1.18 version. The one I linked previously is on master.

As for how to build, Jackson Core has become incompatible with older versions of gladle FasterXML/jackson-core#955 (comment). You just need to upgrade the gradle version by changing the value in gradle-wrapper.properties. You may also need to remove the changelog task as it appears the changelog.md file doesn't exist. Here are the required changes:

  • Change gradle version. file: ./gradle/wrapper/gradle-wrapper.properties
    image

  • Remove changelog generation from build steps. file: ./build.gradle
    image

Then build it with ./gradlew build (use .\gradlew.bat build if you're on windows) from the root directory of the project and voilà, the jar will be inside build/libs. Remove the old version from your mods folder and place the new one in. Configure the ordering from the main menu and it should work.

Here's a download link if you can't be bothered. https://gofile.io/d/Z6rtgo

@ABruel
Copy link

ABruel commented Sep 2, 2023

@moderngamer327 Remember to also checkout this pr with gh pr checkout 157. If you don't have gh, you can download it from https://cli.github.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants