Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the entire static site to Hugo #30

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

VoyTechnology
Copy link
Member

@VoyTechnology VoyTechnology commented Mar 14, 2018

Main benefit is that we don't have to do weird checking out of gh-pages
and its easier to modify certain pages.

Visually, there is very little difference. Sure my CSS could be a bit better but that is easy to fix.

Instructions on enabling the CI to build:

  1. Setup project on CircleCI: https://circleci.com/add-projects/gh/iandioch/cpssd.net
  2. Authorize CircleCI to use personal git key to push to the repo (gh-pages) branch: https://circleci.com/gh/andioch/cpssd.net/edit#checkout

Feel free to PM me or add comments below.

@VoyTechnology
Copy link
Member Author

This change requires CircleCI to be set up in order to deploy the pages to gh-pages

@byxor
Copy link
Contributor

byxor commented Mar 15, 2018

I don't know what any of this means, but it seems like a big change. Weren't we already using Hugo to generate the website?

@VoyTechnology
Copy link
Member Author

Currently you need to checkout gh-pages, and the site is being generated by Jekyll. If you want to try and develop anything locally you need to download ruby and all its dependencies (https://jekyllrb.com/docs/installation/), Hugo comes as a standard 5MB statically compiled executable (https://gohugo.io/getting-started/installing/) and you can test locally with hugo server

@byxor
Copy link
Contributor

byxor commented Mar 15, 2018

I don't see any issues without checking out gh-pages. Although not requiring a bunch of external dependencies seems nice.

@iandioch
Copy link
Contributor

This is a lot of complexity being added, but I'm not sure what the benefit is. Everyone is familiar with gh-pages and how it works. How often do you actually need to develop locally?

I won't get the chance before next week to try running it and seeing how it works, will report back when I do.

@VoyTechnology
Copy link
Member Author

VoyTechnology commented Mar 15, 2018

The only additional complexity is CircleCI, and only for @iandioch, once, and even that can be omitted and the scripts can be ran by hand.

A more optimal approach overall would be to have a separate org with multiple maintainers, and moving the repo there. But that is its own issue.

@sentriz sentriz mentioned this pull request Apr 16, 2018
@byxor
Copy link
Contributor

byxor commented Apr 18, 2018

If this gets merged, is the entire site going to break? I want to submit a PR but I'm holding off until this PR is dealt with.

@VoyTechnology
Copy link
Member Author

@sentriz made a PR to my PR and he was very happy with the simplicity

(right @sentriz? Plz say it was easier to add data to Hugo rewrite than current site, plz, plz)

@byxor
Copy link
Contributor

byxor commented Apr 19, 2018

@VoyTechnology It's late, you should go to bed. 😉

@VoyTechnology
Copy link
Member Author

@byxor 99% sure it will. But I'll be happy to update this PR if you make and merge your PR to the current site.

## Released under MIT Licence

The Emerald theme for Jekyll is Copyright (c) 2015 Jacopo Rabolini
Copyright (c) 2018 CPSSD Students
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree with this file rename. Regardless, there's no reason why this change should be part of this PR - put it in a different one.

README.md Outdated

Anyone can add a post to the blog. We'll figure out some way of organising that as it goes. Just copy the format of an existing post and submit a pull request.

Anybody can add a post to the blog. Just create a new file in `content/blog/`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph and the previous paragraph need to be merged.

config.yaml Outdated
@@ -0,0 +1,16 @@
baseURL: https://cpssd.net
disablePathToLower: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y tho

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was some time ago that I did it. I believe I imported the site from Jekyll and it was the default setting. I believe this basically means that if a file is called SomeBlogPost.md, this would generate SomeBlogPost.html from it instead of someblogpost.html. I can remove that line if you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like nbd

config.yaml Outdated
@@ -0,0 +1,16 @@
baseURL: https://cpssd.net
disablePathToLower: true
languageCode: en-us
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en-ie

[1]: https://dcu.ie
[2]: /projects
[3]: /blog/rip
[4]: https://web.archive.org/web/20170720163904/http://www.computing.dcu.ie/undergraduate/pssd/computational-problem-solving-software-development-cpssd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to web.archive.org

place on the 23rd of February, and lots of CPSSD first and second years crowded
in the DCU Hashcode hub to compete.

<!--more-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this comment do something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It allows you to define the end of a summary. So if I have a long article, and I place <!--more--> after the first paragraph, the article list would show only the first paragraph, and you will have to click on the article to view the whole thing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice.

@@ -0,0 +1,6 @@
---
# Front matter comment to ensure Jekyll properly reads file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jekyll?

width: 15%;
height: 1px;
margin: 1rem auto;
background-color: lightgrey;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does lightgrey really work instead of lightgray?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

.date {
color: grey;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above re: grey/gray.

@VoyTechnology
Copy link
Member Author

PTAL @iandioch

config.yaml Outdated
@@ -0,0 +1,16 @@
baseURL: https://cpssd.net
disablePathToLower: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like nbd

README.md Outdated
probably prefix it with a year if its a recurring event or something. You can
just copy the definition at the top from another file.
Anyone can add a post to the blog. We'll figure out some way of organising that
as it goes. Just copy the format of an existing post and submit a pull
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I meant they should be merged, I didn't just mean stuck together 😛 The two paragraphs are near duplicates ("Anyone can add a post to the blog", then later, "Anybody can add a post to the blog").

Just de-dupe, and go with something like:

"Anyone can add a post to the blog. Just create a new file in content/blog, probably prefix it with a year if it's a recurring event or something. You can just copy the definition at the top from another file. Then submit a pull request."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

@VoyTechnology
Copy link
Member Author

PTAL @iandioch, hopefully for the last time :)

README.md Outdated

Feel free to submit pull requests, make issues, and edit anything and everything.

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello

README.md Outdated
Anybody can add a post to the blog. Just create a new file in `content/blog/`,
probably prefix it with a year if its a recurring event or something. You can
just copy the definition at the top from another file.
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi fren

README.md Outdated
request. Anybody can add a post to the blog. Just create a new file in
`content/blog/`, probably prefix it with a year if its a recurring event or
something. You can just copy the definition at the top from another file.
>>>>>>> 842ac2d6d56cd309f322a44976cd8f876060b4c0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waddup

@byxor
Copy link
Contributor

byxor commented Jul 17, 2018

🍿 eating popcorn

@sentriz
Copy link
Member

sentriz commented Jul 19, 2018


how2fix

@VoyTechnology
Copy link
Member Author

@sentriz your issue is now fixed (I was using old version of hugo), @iandioch Everything is ready for final approval and merge.

@iandioch
Copy link
Contributor

TY - will take a look after work this evening xo

@sentriz
Copy link
Member

sentriz commented Jul 19, 2018

@VoyTechnology VoyTechnology force-pushed the hugo branch 2 times, most recently from f4e1b27 to 5cae389 Compare July 19, 2018 20:38
@VoyTechnology
Copy link
Member Author

Please report any issues on #34

@VoyTechnology VoyTechnology merged commit 243f80a into cpssd-students:master Jul 19, 2018
@VoyTechnology VoyTechnology deleted the hugo branch July 19, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants