-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the entire static site to Hugo #30
Conversation
This change requires CircleCI to be set up in order to deploy the pages to |
I don't know what any of this means, but it seems like a big change. Weren't we already using Hugo to generate the website? |
Currently you need to checkout |
I don't see any issues without checking out |
This is a lot of complexity being added, but I'm not sure what the benefit is. Everyone is familiar with gh-pages and how it works. How often do you actually need to develop locally? I won't get the chance before next week to try running it and seeing how it works, will report back when I do. |
The only additional complexity is CircleCI, and only for @iandioch, once, and even that can be omitted and the scripts can be ran by hand. A more optimal approach overall would be to have a separate org with multiple maintainers, and moving the repo there. But that is its own issue. |
If this gets merged, is the entire site going to break? I want to submit a PR but I'm holding off until this PR is dealt with. |
@VoyTechnology It's late, you should go to bed. 😉 |
@byxor 99% sure it will. But I'll be happy to update this PR if you make and merge your PR to the current site. |
## Released under MIT Licence | ||
|
||
The Emerald theme for Jekyll is Copyright (c) 2015 Jacopo Rabolini | ||
Copyright (c) 2018 CPSSD Students |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disagree with this file rename. Regardless, there's no reason why this change should be part of this PR - put it in a different one.
README.md
Outdated
|
||
Anyone can add a post to the blog. We'll figure out some way of organising that as it goes. Just copy the format of an existing post and submit a pull request. | ||
|
||
Anybody can add a post to the blog. Just create a new file in `content/blog/`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph and the previous paragraph need to be merged.
config.yaml
Outdated
@@ -0,0 +1,16 @@ | |||
baseURL: https://cpssd.net | |||
disablePathToLower: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was some time ago that I did it. I believe I imported the site from Jekyll and it was the default setting. I believe this basically means that if a file is called SomeBlogPost.md
, this would generate SomeBlogPost.html
from it instead of someblogpost.html
. I can remove that line if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like nbd
config.yaml
Outdated
@@ -0,0 +1,16 @@ | |||
baseURL: https://cpssd.net | |||
disablePathToLower: true | |||
languageCode: en-us |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en-ie
[1]: https://dcu.ie | ||
[2]: /projects | ||
[3]: /blog/rip | ||
[4]: https://web.archive.org/web/20170720163904/http://www.computing.dcu.ie/undergraduate/pssd/computational-problem-solving-software-development-cpssd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to web.archive.org
place on the 23rd of February, and lots of CPSSD first and second years crowded | ||
in the DCU Hashcode hub to compete. | ||
|
||
<!--more--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this comment do something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It allows you to define the end of a summary. So if I have a long article, and I place <!--more-->
after the first paragraph, the article list would show only the first paragraph, and you will have to click on the article to view the whole thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice.
static/css/main.scss
Outdated
@@ -0,0 +1,6 @@ | |||
--- | |||
# Front matter comment to ensure Jekyll properly reads file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jekyll?
width: 15%; | ||
height: 1px; | ||
margin: 1rem auto; | ||
background-color: lightgrey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does lightgrey
really work instead of lightgray
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS took colour names from X11, including duplicates. So yeah, it works, TIL.
} | ||
|
||
.date { | ||
color: grey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above re: grey
/gray
.
PTAL @iandioch |
config.yaml
Outdated
@@ -0,0 +1,16 @@ | |||
baseURL: https://cpssd.net | |||
disablePathToLower: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like nbd
README.md
Outdated
probably prefix it with a year if its a recurring event or something. You can | ||
just copy the definition at the top from another file. | ||
Anyone can add a post to the blog. We'll figure out some way of organising that | ||
as it goes. Just copy the format of an existing post and submit a pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I meant they should be merged, I didn't just mean stuck together 😛 The two paragraphs are near duplicates ("Anyone can add a post to the blog", then later, "Anybody can add a post to the blog").
Just de-dupe, and go with something like:
"Anyone can add a post to the blog. Just create a new file in content/blog
, probably prefix it with a year if it's a recurring event or something. You can just copy the definition at the top from another file. Then submit a pull request."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
PTAL @iandioch, hopefully for the last time :) |
README.md
Outdated
|
||
Feel free to submit pull requests, make issues, and edit anything and everything. | ||
|
||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello
README.md
Outdated
Anybody can add a post to the blog. Just create a new file in `content/blog/`, | ||
probably prefix it with a year if its a recurring event or something. You can | ||
just copy the definition at the top from another file. | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi fren
README.md
Outdated
request. Anybody can add a post to the blog. Just create a new file in | ||
`content/blog/`, probably prefix it with a year if its a recurring event or | ||
something. You can just copy the definition at the top from another file. | ||
>>>>>>> 842ac2d6d56cd309f322a44976cd8f876060b4c0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waddup
🍿 eating popcorn |
TY - will take a look after work this evening xo |
f4e1b27
to
5cae389
Compare
Please report any issues on #34 |
Main benefit is that we don't have to do weird checking out of gh-pages
and its easier to modify certain pages.
Visually, there is very little difference. Sure my CSS could be a bit better but that is easy to fix.
Instructions on enabling the CI to build:
gh-pages
) branch: https://circleci.com/gh/andioch/cpssd.net/edit#checkoutFeel free to PM me or add comments below.