Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA Cleanup #13

Merged
merged 5 commits into from
Dec 11, 2023
Merged

GHA Cleanup #13

merged 5 commits into from
Dec 11, 2023

Conversation

cmazakas
Copy link
Collaborator

@cmazakas cmazakas commented Dec 6, 2023

  • Manually specify cmake-version because of cmake-3.28-rc segfaulting on osx
  • Relocate set(output directory) for add_subdirectory tests only
  • fix typo in "build-type"

There's an issue where the 3.28 rc candidate for osx segfaults. Specifying cmake version requirements seem to prevent the required actions from downloading this.
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #13 (5689d39) into develop (4ed26f4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #13   +/-   ##
========================================
  Coverage    99.07%   99.07%           
========================================
  Files           28       28           
  Lines          755      755           
========================================
  Hits           748      748           
  Misses           7        7           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed26f4...5689d39. Read the comment docs.

@cmazakas cmazakas merged commit dafa29e into cppalliance:develop Dec 11, 2023
39 checks passed
@cmazakas cmazakas deleted the fix/gha-cleanup branch December 11, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants