Add logs for revoke sharing when trashed

cozy · Jan 17, 2022 · 1b54ee3 · 1b54ee3
1 parent 1c1092a
commit 1b54ee3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/model/sharing/revoke_trashed.go b/model/sharing/revoke_trashed.go
@@ -30,13 +30,14 @@ func revokeTrashed(db prefixer.Prefixer, sharingID string) {
 		Domain: db.DomainName(),
 	}
 
+	log := inst.Logger().WithNamespace("sharing")
+	log.Infof("revokeTrashed called for sharing %s", sharingID)
 	if s.Owner {
 		err = s.Revoke(inst)
 	} else {
 		err = s.RevokeRecipientBySelf(inst, SharingDirAlreadyTrashed)
 	}
 	if err != nil {
-		inst.Logger().WithNamespace("sharing").
-			Errorf("revokeTrashed failed for sharing %s: %s", sharingID, err)
+		log.Errorf("revokeTrashed failed for sharing %s: %s", sharingID, err)
 	}
 }
diff --git a/model/vfs/couchdb_indexer.go b/model/vfs/couchdb_indexer.go
@@ -731,7 +731,10 @@ func (c *couchdbIndexer) checkTrashedFileIsShared(doc *FileDoc) {
 
 // RevokeSharingFunc does nothing. It will will be overridden from the sharing
 // package.
-var RevokeSharingFunc = func(db prefixer.Prefixer, sharingID string) {}
+var RevokeSharingFunc = func(db prefixer.Prefixer, sharingID string) {
+	logger.WithNamespace("vfs").WithField("critical", "true").
+		Errorf("RevokeSharingFunc called without having been overridden!")
+}
 
 // revokeSharing is called when the main file/dir of a sharing is trashed, in
 // order to revoke the sharing.