Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix circular dependency issue #166

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: fix circular dependency issue #166

merged 1 commit into from
Dec 3, 2024

Conversation

shoom3301
Copy link
Contributor

@shoom3301 shoom3301 commented Dec 3, 2024 •
edited
Loading

Description

  1. We import import { getLogger } from "../utils"; in types/model.ts
  2. export * from "./model"; is in types/index.ts
  3. types/index.ts is used in utils/misc.ts
  4. utils/misc.ts is exported from "../utils"

anxolin
anxolin approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

image

Closing then #165 in favour of your PR as you found the cause

@anxolin anxolin mentioned this pull request Dec 3, 2024
Closed
@shoom3301 shoom3301 merged commit 4524b88 into main Dec 3, 2024
4 checks passed
@shoom3301 shoom3301 deleted the fix/logger-import-fix branch December 3, 2024 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoom3301 @anxolin