Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: addressed nits #111

Merged
merged 3 commits into from
Oct 18, 2023
Merged

chore: addressed nits #111

merged 3 commits into from
Oct 18, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Oct 13, 2023

Description

Follow up on comments from #102

@anxolin anxolin mentioned this pull request Oct 13, 2023
Merged
mfw78
mfw78 approved these changes Oct 14, 2023
View reviewed changes
src/utils/metrics.ts Outdated Show resolved Hide resolved
@anxolin @mfw78
chore: change name
5e5bfe7 
Co-authored-by: mfw78 <[email protected]>
@anxolin anxolin merged commit cc446f3 into main Oct 18, 2023
3 checks passed
@anxolin anxolin deleted the nits-naming-metrics3 branch October 18, 2023 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfw78 mfw78 mfw78 approved these changes

Assignees

@mfw78 mfw78

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anxolin @mfw78